MediaElch icon indicating copy to clipboard operation
MediaElch copied to clipboard

[File] Add Filesystem class for better testing

Open bugwelle opened this issue 3 years ago • 2 comments

bugwelle avatar Apr 23 '21 17:04 bugwelle

The idea was to pass an explicit file system object to each class that handles files. However, I now think that having global functions or at least a singleton isn't bad in this case. Simply because we're not a library, we're an app. Having a central place that handles files is useful here.

bugwelle avatar Dec 19 '21 14:12 bugwelle

Further ideas:

  • Should there be a central object that others can connect to?
  • Should we leave it at the current installFileSystemLog state? We can move to the before mentioned object quickly by adding it to FileSystemLog.cpp

bugwelle avatar Dec 26 '21 17:12 bugwelle

Discarding. See https://github.com/Komet/MediaElch/issues/847#issuecomment-1908709436

bugwelle avatar Jan 24 '24 18:01 bugwelle