gettext-rs icon indicating copy to clipboard operation
gettext-rs copied to clipboard
verified publisher icon Koka

Update to gettext 22.5

Open dennisschagt opened this issue 1 year ago • 2 comments

Resolves https://github.com/Koka/gettext-rs/issues/114 Resolves https://github.com/Koka/gettext-rs/issues/117

Relevant gnulib commit: 0cc39712

  • [x] Look through release notes to find possibly important configuration options

  • [x] FInd out why integration test is failing on my system: cargo test -p gettext-rs --test integration

    running 11 tests error: test failed, to rerun pass -p gettext-rs --test integration

    Caused by: process didn't exit successfully: /home/dennis/tmp-projects/gettext-rs/target/debug/deps/integration-7e0d0a9f78988c74 (signal: 6, SIGABRT: process abort signal)

    • Turns out this was caused by passing in an invalid value for the category argument of dcgettext(). From https://www.gnu.org/software/libc/manual/html_node/Translation-with-gettext.html:

      Normally the available values are LC_CTYPE, LC_COLLATE, LC_MESSAGES, LC_MONETARY, LC_NUMERIC, and LC_TIME. Please note that LC_ALL must not be used and even though the names might suggest this, there is no relation to the environment variable of this name.

dennisschagt avatar Mar 05 '24 22:03 dennisschagt

From what I can tell in the comments of https://github.com/gettext-rs/gettext-rs/issues/121, this would address this build failure https://github.com/rustcoreutils/posixutils-rs/actions/runs/10173778299/job/28138428272 , it would be great to get this merged soon!

kellpossible avatar Aug 06 '24 11:08 kellpossible

Resolves #114 Resolves #117

Relevant gnulib commit: 0cc39712

  • [x] Look through release notes to find possibly important configuration options

  • [x] FInd out why integration test is failing on my system: cargo test -p gettext-rs --test integration

    running 11 tests error: test failed, to rerun pass -p gettext-rs --test integration Caused by: process didn't exit successfully: /home/dennis/tmp-projects/gettext-rs/target/debug/deps/integration-7e0d0a9f78988c74 (signal: 6, SIGABRT: process abort signal)

    • Turns out this was caused by passing in an invalid value for the category argument of dcgettext(). From https://www.gnu.org/software/libc/manual/html_node/Translation-with-gettext.html:

      Normally the available values are LC_CTYPE, LC_COLLATE, LC_MESSAGES, LC_MONETARY, LC_NUMERIC, and LC_TIME. Please note that LC_ALL must not be used and even though the names might suggest this, there is no relation to the environment variable of this name.

Resolves #114 Resolves #117

Relevant gnulib commit: 0cc39712

  • [x] Look through release notes to find possibly important configuration options

  • [x] FInd out why integration test is failing on my system: cargo test -p gettext-rs --test integration

    running 11 tests error: test failed, to rerun pass -p gettext-rs --test integration Caused by: process didn't exit successfully: /home/dennis/tmp-projects/gettext-rs/target/debug/deps/integration-7e0d0a9f78988c74 (signal: 6, SIGABRT: process abort signal)

    • Turns out this was caused by passing in an invalid value for the category argument of dcgettext(). From https://www.gnu.org/software/libc/manual/html_node/Translation-with-gettext.html:

      Normally the available values are LC_CTYPE, LC_COLLATE, LC_MESSAGES, LC_MONETARY, LC_NUMERIC, and LC_TIME. Please note that LC_ALL must not be used and even though the names might suggest this, there is no relation to the environment variable of this name.

Bingo, that's probably exactly what I needed to fix my issue https://github.com/gettext-rs/gettext-rs/issues/127

EDLLT avatar Sep 17 '24 12:09 EDLLT