gettext-rs icon indicating copy to clipboard operation
gettext-rs copied to clipboard

Fix build failure on clang 16: turn off incompatible-function-pointer-types

Open Endle opened this issue 2 years ago • 5 comments

This PR is a workaround for https://github.com/Koka/gettext-rs/issues/114

Endle avatar Dec 14 '23 02:12 Endle

@Minoru Can you have a review? Thank you

Endle avatar Dec 14 '23 15:12 Endle

This does not work on latest MacOS. The output of clang --version:

❯ clang --version
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

crab2313 avatar Apr 20 '24 08:04 crab2313

@crab2313 can you share your log?

Endle avatar Apr 20 '24 13:04 Endle

@crab2313 can you share your log?

Nothing special. Clang of MacOS SDK prints different format of version string. So this implementation simply can't get the version of clang.

crab2313 avatar Apr 20 '24 13:04 crab2313

Thank you for pointing out! I see why it's failing now. I'll do a quick fix to it later

Endle avatar Apr 20 '24 16:04 Endle

Thanks! However, I don't want to add a dependency on regex just for this. I'll make an alternative PR where the warning is disabled unconditionally, and see what CI thinks about it.

Minoru avatar Jul 20 '24 11:07 Minoru

Thanks! However, I don't want to add a dependency on regex just for this. I'll make an alternative PR where the warning is disabled unconditionally, and see what CI thinks about it.

Why not simply update to gettext 0.22.5 which solve this issue too.

crab2313 avatar Jul 20 '24 11:07 crab2313

Because I want to move away from tarballs for #12, but that might take time, so I'll push a smaller release before that.

Minoru avatar Jul 20 '24 14:07 Minoru