Nikita Kniazev

Results 256 comments of Nikita Kniazev

> > I'm pretty sure it is tested indirectly via error handler tests, > > I haven't found any references to `x3::position_cache` in the tests. https://github.com/boostorg/spirit/blob/e30073e5bebb8102c73d1ad3588bf3f68cec2b64/include/boost/spirit/home/x3/support/utility/error_reporting.hpp#L73

> > I haven't made deep inspection of what could go wrong with doing variant, have you? At least the question about how crude is unused_type in visitor will be,...

> I can't think of any downside to making `embed-manifest-via=linker` the default unconditionally across the board, so that the manifest tool is no longer needed. It requires VC11+

> Interesting. I use it unconditionally: [boostorg/container_hash@`87c9eef`/.appveyor.yml#L72](https://github.com/boostorg/container_hash/blob/87c9eefe6ea8ed3cc0a7381e2580c1ce562e6acd/.appveyor.yml#L72) > > and the `msvc-9.0,msvc-10.0` jobs pass: [ci.appveyor.com/project/pdimov/container-hash/build/job/tbqpop4ap9qveye6](https://ci.appveyor.com/project/pdimov/container-hash/build/job/tbqpop4ap9qveye6) I believe your input is saliently overridden by B2 for VC

`embed-manifest-via=linker` is broken on `clang-win`, it disables manifest embedding completely (disables mt invocation, but doesn't add `/manifest:embed` to link flags). Fixing that will expose all uses of `embed-manifest-via=linker` to a...

On the one side it makes sense, msvc compiler and linker doesn't support long path even with windows opt-in long path support feature. But on the other, it's more like...

> In order for b2 to use that flag both `address-model=32` and an _appropriate_ `architecture=A` properties have to be present in the requested property set. I consider that a bug...

> Philosophically it is not correct to add `-m32` unless the target architecture is known to be appropriate. Whether it is practically better is debateable. Consider someone building for their...

I have an idea that can alleviate the issue and it involves a change that I've wanted to make for a while: feature minimization should consider toolset defaults and requirements...

I though this might happen, but in my mind `windres` can only appear in the `PATH` when `g++` is also from MinGW. How you end up with a system like...