LuaFormatter
LuaFormatter copied to clipboard
compile for win32 using docker and mxe
I needed the latest commit to be compiled for windows, so I used Docker and mxe project to cross compile for windows. This commit can be used as a base step to use github actions to compile automatically. The only thing that did not work out of the box is the "try_run" (to test the c++17 compiler) CmakeList option, not sure why, so I simply added an option to disable.
I was not sure if the current Dockerfile had any dependencies, since I don't fully understand this project. I will change the Dockerfile next time I have some free time.
"It's more reasonable to disable the test for known correct compilers. For instance: clang >= 10.0.0 and gcc >= 9.0.0."
I use the mxe cross compiling project in which I can select the compiler version (in this case, i chose gcc10). The default CMakeLists.txt behavior is still to test for the c++17. I simply added the option to disable, but at the same time I know that it's going to compile with the right version, in which is kind what you suggested. Still think I should do something else regarding the CMakelists.txt?
"It's more reasonable to disable the test for known correct compilers. For instance: clang >= 10.0.0 and gcc >= 9.0.0."
I use the mxe cross compiling project in which I can select the compiler version (in this case, i chose gcc10). The default CMakeLists.txt behavior is still to test for the c++17. I simply added the option to disable, but at the same time I know that it's going to compile with the right version, in which is kind what you suggested. Still think I should do something else regarding the CMakelists.txt?
It's better to have CMake disable it "automagically" for newer compilers which are known to be correct.
It's just a matter of a if() statement regarding the compiler versions (clang, gcc, etc...).