Kohei Moroi

Results 15 comments of Kohei Moroi

@sangcomz > Thanks for the PR. And sorry for replying so late. The PR you wrote doesn't seem to open when the adapter is null, is that correct? Yes, we...

@sangcomz Sorry for the rush. It's unexpected behavior, and it's tough to address this kind of issue we can not reproduce. However, the crash surely occurs on production as the...

> @KoheiMoroi It would be nice to inform the error situation through toast or message dialog. And I wish that message could be customized too. Could you work on this...

Here is error log(from beginning to the crash): ---------------------------- PROCESS STARTED (29638) for package com.sangcomz.fishbundemo ---------------------------- 2022-12-06 10:47:10.062 29638-29638 ziparchive com.sangcomz.fishbundemo W Unable to open '/data/data/com.sangcomz.fishbundemo/code_cache/.overlay/base.apk/classes9.dm': No such file or...

@sangcomz We display a Dialog with a localized message when that error occurs in the presenter class. Plus, I added Japanese string resources. [- add SimpleDialog under the common dir](https://github.com/sangcomz/FishBun/pull/254/commits/a8d49bca8a45338f2ff12a5ed849583c9bb921d8)

> @KoheiMoroi I checked the part you fixed. thanks! > > I've been thinking about it additionally, how about changing to using toast instead of dialog? > > Because dialog...

@sangcomz I changed to display a toast instead of a dialog. You can confirm it by this [commit](https://github.com/sangcomz/FishBun/pull/254/commits/b77dfa482b06a4cd62ef5208093b07a1ba3ad6e2).

@sangcomz Thanks to my colleague, we can reproduce the crash consistently by adding `androidx.fragment:fragment-ktx:1.5.5` dependency. I am trying to understand why this causes the crash and is related to the...

It's my pleasure. Please do not hesitate to let me know if there is something to help.

> @KoheiMoroi I'm trying to reproduce it now, but does it happen when I simply add implementation "androidx.fragment:fragment-ktx:1.5.5" to the fishbundemo project? I seem to be working fine, are there...