ets2-local-radio icon indicating copy to clipboard operation
ets2-local-radio copied to clipboard

Update cities-ets2 Road to Asia, Red Sea Map, Viva Malta, Sibir Map, Volga Map, Project Greenland

Open keremguvercin opened this issue 3 years ago • 7 comments

keremguvercin avatar Sep 13 '21 01:09 keremguvercin

Would you mind adding support for JRR too?

rafaelkai avatar Oct 09 '21 16:10 rafaelkai

These maps are the maps that I used. I didn't use the Indonesian map. But I can use it.

keremguvercin avatar Oct 10 '21 22:10 keremguvercin

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret e4d436e13824e219a86dd3eff7b09ad6d0798852 web/stations/stations-europe.js View secret
- Generic High Entropy Secret fe945f41bafa67641fe2b98a344dc050bc9d89e8 web/stations/stations-europe.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Sep 12 '22 13:09 gitguardian[bot]

I have merged #161 and #171 into this, as they all depend on each other.

This is now quite the PR due to the merging of master. The main issue currently is that the logo file names are not representative of the station that uses them. Additionally I believe some stations mainly use the Arabic name (rather than the latinised version). See https://github.com/Koenvh1/ets2-local-radio/blob/master/web/stations/stations-europe.js#L2955 for an example. Personally I believe it requires some improvements before I am willing to merge it, and seeing how this has already been open for a year, I am personally not that interested in resolving the outstanding issues for this PR.

@04Marcus Could you check whether you want to use anything from this?

Koenvh1 avatar Sep 12 '22 13:09 Koenvh1

Will this ever go in, or is this fully abandoned? (right now approaching Turkmenistan) :D But I guess this would have been more meaningfull to be 1 PR per country - instead of 1 mega PR - as unlikely anyone will want to touch 5k+ PR...

AssassinLV avatar Jan 08 '24 22:01 AssassinLV