zigbee2mqtt icon indicating copy to clipboard operation
zigbee2mqtt copied to clipboard

The big cleanup

Open Koenkk opened this issue 1 year ago • 1 comments

See https://github.com/Koenkk/zigbee2mqtt/discussions/24198

Koenkk avatar Oct 03 '24 19:10 Koenkk

For https://github.com/Koenkk/zigbee2mqtt/pull/24200/commits/a2237ed0276ebd68f54bd2293b8e94471e1d9c4f

Removed:

  • mqtt:
    • bridge/log
    • bridge/(bind|unbind)/
    • bridge/group/(.+)/(remove|add|remove_all)
    • bridge/group/remove_all
    • bridge/networkmap/${data.message}
    • bridge/ota_update/
  • update_available from OTA update payload/state
  • default group converters (always use members converters instead)
  • retrieve_state from Device/Group options

Fixed:

  • Typing for getEntityPublishPayload in OTAUpdate

Nerivec avatar Oct 04 '24 17:10 Nerivec

For https://github.com/Koenkk/zigbee2mqtt/pull/24200/commits/7b402b4c9ce39f534758f883747ee8e2d0e10c96

Removed:

  • /bridge/config/*
  • Settings in advanced:
    • availability_timeout
    • availability_blocklist
    • availability_passlist
    • availability_blacklist
    • availability_whitelist
    • soft_reset_timeout
    • report
  • Unused zigbee-herdsman wrapper API reset
  • Unused device API isIkeaTradfri
  • Unused utils

Nerivec avatar Oct 07 '24 20:10 Nerivec

I figure we do a separate PR at the end to cleanup all removed settings from settings.schema.json and the necessary changes in settings.ts?

Nerivec avatar Oct 07 '24 20:10 Nerivec

For https://github.com/Koenkk/zigbee2mqtt/pull/24200/commits/7f4e15f39012cea3b23fde57ac53fe2c29f12cc8

Removed:

  • /bridge/configure
  • legacy_availability_payload setting
  • legacy_api setting
  • Legacy stuff from configure (previously missed, wasn't using legacy_api setting)

@Koenkk I'll let you do the stuff for HA. A search for legacy (whole-repo) should identify most remaining points.

Nerivec avatar Oct 07 '24 22:10 Nerivec

Removed some leftovers and create a PR for the docs: https://github.com/Koenkk/zigbee2mqtt.io/pull/3094

Ready for merge?

Koenkk avatar Oct 11 '24 21:10 Koenkk

There's the HA legacy stuff left to do. You're going to do that in a separate PR?

Nerivec avatar Oct 12 '24 09:10 Nerivec

Yes will do the HA stuff in a separate PR

Koenkk avatar Oct 12 '24 11:10 Koenkk

How about these? https://github.com/Koenkk/zigbee2mqtt/blob/e06848db8c5ad247c27e959eb85465a30134769f/lib/extension/bridge.ts#L73-L77

Nerivec avatar Oct 12 '24 13:10 Nerivec