Koen Kanters

Results 1455 comments of Koen Kanters

@burmistrzak yes, the configs are then updated which will the be further used by the ha extension. As an alternative we could also return the new configs, functionality it doesnt...

@burmistrzak how do you plan to set the `mode_command_topic`? since you cannot put logic like: `payload.mode_command_topic = commandTopic.substring(0, commandTopic.lastIndexOf('/system_mode'));` in there

@burmistrzak I see no other way indeed, this would also allow for e.g. deleting entities

> I'll also have to define the interfaces for MockProperty & DiscoveryEntry in [src/lib/types.ts](https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/lib/types.ts), right? That's fine! After this PR is updated it can be merged.

While fixing the tests, can you guys confirm that the [discovery payload](https://github.com/Koenkk/zigbee2mqtt/pull/23075/files#diff-0eca7eb0935564159201825dcf3b6a0c41cf0d23c8a183a7a2c618a933af5ee7R907) is correct?

Great, I've fixed the tests (will pass once https://github.com/Koenkk/zigbee-herdsman-converters/pull/7720 is merged), can you both review this PR and https://github.com/Koenkk/zigbee-herdsman-converters/pull/7720 ?

@nurikk this may be a possible improvement for this page. Starting with z2m the update object will have an `installed_version` and `latest_version`. This is used in Zigbee to determine wether...

@bluemoehre looks really nice!

@bluemoehre yes, feel free to contact me at the z2m discord.

Could you provide the debug log when triggering a hold action? See [this](https://www.zigbee2mqtt.io/guide/configuration/logging.html) on how to enable debug logging.