django-q icon indicating copy to clipboard operation
django-q copied to clipboard

"Retry and timeout are misconfigured" as per default settings

Open amo13 opened this issue 4 years ago • 7 comments

On a fresh installation without altered configuration, the new warning pops up:

/usr/lib/python3.9/site-packages/django_q/conf.py:136: UserWarning: Retry and timeout are misconfigured. Set retry larger than timeout, 
        failure to do so will cause the tasks to be retriggered before completion. 
        See https://django-q.readthedocs.io/en/latest/configure.html#retry for details.
  warn("""Retry and timeout are misconfigured. Set retry larger than timeout,

Since I did not change any configuration, I looked up the default conf.py in this repo to find that timeout is set to none while retry is set to 60s. Should the the timeout in the default conf.py be set to an appropriate value so that it does not trigger the new warning after an unaltered default installation?

amo13 avatar Apr 03 '21 13:04 amo13

Yes, and the docs need to be updated too. It happened because of a recent PR. Either that or we don't show the warning on no timeout configured.

Koed00 avatar Apr 03 '21 14:04 Koed00

Awesome! I can create the pull request, but I don't know what timeout value would be sane. 30? 59?

amo13 avatar Apr 03 '21 15:04 amo13

I just had this issue on a fresh install with version 1.3.9 which is surprising since it looks like this PR was merged back in May...

mike-bell-gettogetherai avatar Aug 24 '21 20:08 mike-bell-gettogetherai

It was not merged, only the modification in the documentation. I suggested the corresponding code modification in a separate pull request, but my code edits seem to create trouble elsewhere. Unfortunately, I do not know any python and cannot help any further.

#537

amo13 avatar Aug 24 '21 21:08 amo13

Ah ok, thanks for confirming!

mike-bell-gettogetherai avatar Aug 24 '21 21:08 mike-bell-gettogetherai

Is this warning safe to ignore if there is no timeout configured?

seaturtlecode avatar Oct 18 '21 16:10 seaturtlecode

The same issue comes when we set the timeout value to None.

How can we set timeout value to None and not get this warning? Tried keeping retry value as None, but same warning persist.

abhijeet-electrum avatar Jul 15 '22 09:07 abhijeet-electrum