Jakub Beránek
Jakub Beránek
> Teachers sometimes allow students to upload materials for tests to Kelvin. If Kelvin is used as a side channel to upload materials for tests where students don't have internet...
Hi, thanks for the PR! This looks really cool. There is some functionality that is not strictly related to IP filtering, so it would be great to merge it separately....
This should be somehow combined with https://github.com/mrlvsb/kelvin/pull/787, so that we don't have two ways of combining rooms.
I see the deployment service as part of the Kelvin codebase, and not something separate. I don't want to maintain two separate workflow files that do almost the same thing.
The deployment service is Kelvin-specific, and Kelvin currently can't be easily deployed without it, so Kelvin depends on it. I would prefer keeping everything together.
I mean, we can definitely use it for more stuff within Kelvin itself, e.g. for evaluators, that's fine. But I don't want to maintain a service that would be usable...
You don't really need to be assigned on an issue to work on it, but I assigned you :)
Thanks! I'll leave this open until December, if you don't mind, just in case GitHub changes their minds...
Looks like nothing changed from GitHub's side, let's go ahead with this. Thank you!
Note that ideally we should have no synchronize button in new bors, it synchronizes automatically. What we might do though is store the mapping of PRs to rollups, that could...