nostros icon indicating copy to clipboard operation
nostros copied to clipboard

Include open source QR reader

Open KoalaSat opened this issue 2 years ago • 8 comments

We want to add an open source de-googled QR reader. Recently we added:

  • https://www.npmjs.com/package/react-native-qrcode-scanner but turns out this library uses react-native-camera which uses Google services https://github.com/KoalaSat/nostros/actions/runs/4531654828/jobs/7982068043

It can be tested by doing these changes:

  • https://github.com/KoalaSat/nostros/pull/467/files#diff-8bb5616fd0c64509171fba4255b434c0b5bdcb63af15074801a087b21c268047
  • https://github.com/KoalaSat/nostros/pull/467/files#diff-1ec9483ede6f8f430214f827b8a59687304223c1c8f8ce32d1dc4ddf986779ab

Any other well maintained QR reader library is a good option as far it's FOSS and de-googled. It looks like the app Conversations (XMPP) makes use of a valid QR reader library.

Rewarded with 300K Sats ⚡ drop a comment below if you want to be assigned.

KoalaSat avatar Mar 27 '23 13:03 KoalaSat

Maybe create a plugin for react-native-camera using zxing or https://github.com/LazarSoft/jsqrcode should be a de-googled package right?!

b4s36t4 avatar Jul 07 '23 16:07 b4s36t4

@KoalaSat I would love to work on this one! Can you assign it to me?

MauroJr avatar Dec 12 '23 03:12 MauroJr

Done @MauroJr ! We have a FOSS validator that is run on every build. Make sure you run it before working on the details to validate the library of your choice is fully FOSS 🙂

KoalaSat avatar Dec 12 '23 07:12 KoalaSat

More details here: https://github.com/KoalaSat/nostros/blob/main/.github/workflows/android-build.yml#L34

KoalaSat avatar Dec 12 '23 07:12 KoalaSat

@KoalaSat Can I also work on this?

b4s36t4 avatar Dec 12 '23 07:12 b4s36t4

Hi @b4s36t4 , sorry but usually we assign bounties to only one person, if you are interested, you can also check this one, wich is pretty much similar https://github.com/KoalaSat/nostros/issues/465

KoalaSat avatar Dec 12 '23 07:12 KoalaSat

@KoalaSat Thank you for assigning it to me. I hope can help.

I'm working on it outside of my working hours which is GMT -5.

I already made a good part of it and I should have a PR Tomorrow before I finish my day, very late in the evening.

After I push it, I'll be happy to get feedback and discuss the implementation.

MauroJr avatar Dec 12 '23 19:12 MauroJr

@KoalaSat Thank you for assigning it to me. I hope can help.

I'm working on it outside of my working hours which is GMT -5.

I already made a good part of it and I should have a PR Tomorrow before I finish my day, very late in the evening.

After I push it, I'll be happy to get feedback and discuss the implementation.

No rush :) take your time!

KoalaSat avatar Dec 13 '23 06:12 KoalaSat