UnitFramesImproved_Vanilla icon indicating copy to clipboard operation
UnitFramesImproved_Vanilla copied to clipboard

Few suggestions

Open Stef-2 opened this issue 5 years ago • 4 comments

Thank you for a very nice addon, I have a few issues and suggestions:

  • user preferences should be saved as SavedVariables instead of CVars.

  • an option to revert to standard looking player frames would be nice.

  • the debuff icons underneath the enemy frame appear to be stuck in a "dark theme" regardless of the "dark mode" option choice.

Stef-2 avatar Sep 19 '18 09:09 Stef-2

@Stef-2 Hey and thanks for the input.

Yea, I only ever worked on this whenever I felt like it and I kind of experimented a bit with the C-Vars and stuff at the end of my last addon development phase so sadly I left it in a pretty critical state. However that's definitely going to change with classic wow around the corner. Starting November 2nd, I'll have 6 days of classic wow demo to start developing a port for the real deal were all this kind of stuff will be fixed.

Would you please elaborate a bit on your second suggestion? Why would'nt you simply disable the addon If you wanted the standard unitframes?

Yes debuff icon borders are dark only atm, I'll consider making a light option.

Ko0z avatar Oct 01 '18 21:10 Ko0z

@Ko0z Sorry for taking this long to respond, I'm fairly new to GitHub,

to elaborate on my second point - I quite like the vanilla look of the player and target frames in the sense that the player name area is separate from the player health one and has a different color to it. This may sound picky but removing the bar which separates them and making the entire thing green or class color messes with that, along with clashing with certain other addons which still only use one of those areas as bars for casting, received healing and such. I'll provide a picture which better explains my points. Again, I very much like your addon for the class icons, ease of moving the frames, dark mode, and customizable text / values in the frames. The option to keep name and health bars separate like in vanilla was just a suggestion. ufi_compare In the target bar on the right you can see how the integrated cast bar provided by enemyframes addon kinda clashes with the look of your frames since the name and health bars are put together.

Stef-2 avatar Oct 22 '18 19:10 Stef-2

@Stef-2 Alright I see your point. Unfortunately It's pretty hard to please each and every user, altough I will certainly try to my best. I have begun making a complete UI and have pretty much rewritten this addon from the ground up in that one but will also update this stand alone when it's ready. Recieved healing and plenty of other features are planned to be in the new version as well as enemy castbars, altough not integrated in the frame itself.. not for now at least. You can get a little preview here https://gitlab.com/Ko0zi/zui

Ko0z avatar Oct 24 '18 17:10 Ko0z

A version of zUI is out now. https://github.com/Ko0z/zUI

ko0zi avatar May 16 '19 20:05 ko0zi