golio

golio copied to clipboard

Migrate to Spectator v5

1

Riot has deprecated the Spectator v4 endpoint and it doesn't seem to work anymore

harmonherring

Fix static champion by ID

7

Changes: - Use ID instead of name to fetch static champion info from DataDragon (e.g. https://ddragon.leagueoflegends.com/cdn/14.8.1/data/en_GB/champion/Wukong.json (403 Forbidden) -> https://ddragon.leagueoflegends.com/cdn/14.8.1/data/en_GB/champion/MonkeyKing.json)

hanscauwenbergh

Support for Request Contexts

1

It doesn't look like any of these requests support caller-defined contexts. @KnutZuidema would you support it if I opened a PR that adds `...WithContext` functions for all existing API requests?...

harmonherring

Found an error in the example

1

``` challengers, _ := client.Riot.League.GetChallenger(api.QueueRankedSolo) ``` ``` QueueRankedSolo not declared by package api ``` The real path is: **github.com/KnutZuidema/golio/riot/lol**

azwc

Add integration tests for API methods using the actual Riot API

KnutZuidema

Removed non-existent fields for the summoner name.

1

This PR removes the non-existent summoner name fields that became obsolete after updating to Spectator v5 and Summoner v4. See the return signatures here: https://developer.riotgames.com/apis#spectator-v5 https://developer.riotgames.com/apis#summoner-v4

Nico-Mayer

Tournament V5

1

Are there plans to support Tournament v5?

Dallin-Cawley