php-github-api icon indicating copy to clipboard operation
php-github-api copied to clipboard

Allow php-http/cache-plugin version 2

Open tacman opened this issue 1 year ago • 5 comments

There's a deprecation warning triggered by this library because it's using 1.x of the php-http/cache-plugin

I think if you simply allowed either ^1.7 || ^2.0 it could use the later version that does not call the deprecated interface.

This might be related to #1119.

Specifically, it's this PR: https://github.com/php-http/cache-plugin/commit/35625293aedba53ca49bb4bd06ac7d12239a89d9

tacman avatar Nov 16 '23 12:11 tacman

@tacman can you provide the deprecation message you get? Thanks!

acrobat avatar Nov 19 '23 21:11 acrobat

I'm not getting it anymore, perhaps they back ported the fix.

tacman avatar Nov 20 '23 12:11 tacman

@tacman I'm still seeing this deprecation, looking at composer.json of v1:

https://github.com/php-http/cache-plugin/blob/1.x/composer.json#L17, it still requires the deprecated interface

aszenz avatar Nov 27 '23 11:11 aszenz

Yep. I'll reopen.

tacman avatar Nov 27 '23 12:11 tacman

Version 2 of php-http/cache-plugin is unreleased, only the branch is created

aszenz avatar Dec 09 '23 12:12 aszenz

2.0.0 release on 2024-02-19 17:02 UTC

ls-philippe-gamache avatar Feb 29 '24 19:02 ls-philippe-gamache