php-github-api icon indicating copy to clipboard operation
php-github-api copied to clipboard

Published 20 hours ago • verified publisher icon KnpLabs

Fix TypeError in ResultPager

Open iwiznia opened this issue 2 years ago • 2 comments

Fixes https://github.com/KnpLabs/php-github-api/issues/1091

Not sure if this is the best fix, if it is not, would love guidance on a better one.

iwiznia avatar Nov 07 '22 17:11 iwiznia

Can someone take a look at this PR? Is this project abandoned?

iwiznia avatar Jan 19 '23 22:01 iwiznia

Hi @iwiznia, thanks for the PR! I'm not sure if this is the "right" fix as we hide the actual error by returning an empty array. I don't understand why the httpClient call doesn't throw an exception (through our GithubExceptionThrower plugin in case of this 500 error.

So for me the fix would rather be to check why there is no exception thrown on this error, something that can be catched by the application and a retry can be executed. Instead of an empty array that could just mean there is no data.

wdyt @iwiznia?

acrobat avatar Jan 25 '23 09:01 acrobat