KnpTimeBundle
KnpTimeBundle copied to clipboard
chore: migrate phpunit from 9 to 10
We'll lose deprecation output, no?
I guess you mean these lines. They are not in the PhpUnit 9 Version. If you plan to add this lines, we have to wait for the bridge to be comaptible with PHPUnit 10. Before this PR can be merged.
<listeners>
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
</listeners>
Ok i see there are deprecation messages in the ci on both versions. Sorry i thought these listeners need to be added to work.
PhpUnit 9 https://github.com/KnpLabs/KnpTimeBundle/actions/runs/5789215654/job/15689774049#step:2:493
PhpUnit 10 https://github.com/KnpLabs/KnpTimeBundle/actions/runs/5794089236/job/15703002897#step:2:545
I don't believe symfony/phpunit-bridge is compatible with phpunit 10 so we'd lose the deprecation checks in the ci.