KnpTimeBundle icon indicating copy to clipboard operation
KnpTimeBundle copied to clipboard

chore: migrate phpunit from 9 to 10

Open Chris53897 opened this issue 1 year ago • 4 comments

Chris53897 avatar Aug 08 '23 07:08 Chris53897

We'll lose deprecation output, no?

kbond avatar Aug 08 '23 08:08 kbond

I guess you mean these lines. They are not in the PhpUnit 9 Version. If you plan to add this lines, we have to wait for the bridge to be comaptible with PHPUnit 10. Before this PR can be merged.

<listeners>
        <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
    </listeners>

Chris53897 avatar Aug 08 '23 09:08 Chris53897

Ok i see there are deprecation messages in the ci on both versions. Sorry i thought these listeners need to be added to work.

PhpUnit 9 https://github.com/KnpLabs/KnpTimeBundle/actions/runs/5789215654/job/15689774049#step:2:493

PhpUnit 10 https://github.com/KnpLabs/KnpTimeBundle/actions/runs/5794089236/job/15703002897#step:2:545

Chris53897 avatar Aug 08 '23 09:08 Chris53897

I don't believe symfony/phpunit-bridge is compatible with phpunit 10 so we'd lose the deprecation checks in the ci.

kbond avatar Aug 08 '23 11:08 kbond