KnpLastTweetsBundle icon indicating copy to clipboard operation
KnpLastTweetsBundle copied to clipboard

Some possible improvements

Open stof opened this issue 14 years ago • 2 comments

I see some possible improvements in the bundle:

  • I confirmed the issue with non-escaped characters in HTML. Use this tweet to confirm (and imagine what could be done by writing an HTML entity in the tweet...)
  • the fetcher allows to change the limit (defaulting to 10) but the controller always rely on the default value of the fetcher
  • the username in the tweets when fetching the tweets for the username Stof70 will be Christophe Coevoet. Is it intended or simply an error when using the data sent by twitter ?
  • The twitter api allows to ignore replies instead of filtering them after getting the results

Also, the bundle forces to ignore replies. Shouldn't it be configurable ?

stof avatar Aug 21 '11 07:08 stof

Also, replacing the links could be changed to use Twitter entities instead of parsing them again (not sure how feasible it is once we do proper escaping)

stof avatar Aug 21 '11 08:08 stof

It will be great also fetch users avatars

maxvanceffer avatar Jan 14 '13 14:01 maxvanceffer