KnpGaufretteBundle icon indicating copy to clipboard operation
KnpGaufretteBundle copied to clipboard

Fix FilesystemMap::getIterator() return type

Open geoffrey-brier opened this issue 3 years ago • 1 comments

Hello :wave:

I fixed the following deprecation :

Deprecated: Return type of Knp\Bundle\GaufretteBundle\FilesystemMap::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /srv/vendor/knplabs/knp-gaufrette-bundle/FilesystemMap.php on line 58

I'm not sure if we should bump the minimal PHP version as well, let me know if it's all right with you :)

geoffrey-brier avatar Nov 28 '21 11:11 geoffrey-brier

Release soon ? :)

adpeyre avatar Dec 14 '21 17:12 adpeyre

Hello,

Thank you very much for contributing to this repository but it only partially addressed the topic. This is why I created https://github.com/KnpLabs/KnpGaufretteBundle/pull/272 which fixes everything and will be released in a new major version.

Nek- avatar Oct 21 '22 13:10 Nek-