KnpGaufretteBundle icon indicating copy to clipboard operation
KnpGaufretteBundle copied to clipboard

Gaufrette FTP defaults to FTP_BINARY, but Bundle defaults to FTP_ASCII

Open Richtermeister opened this issue 11 years ago • 2 comments

There is an inconsistency in the default values between the library and bundle:

Bundle - FTP_ASCII https://github.com/KnpLabs/KnpGaufretteBundle/blob/master/DependencyInjection/Factory/FtpAdapterFactory.php#L52

Library - FTP_BINARY https://github.com/KnpLabs/Gaufrette/blob/master/src/Gaufrette/Adapter/Ftp.php#L48

Not sure that the bundle needs to specify a default, but give that it's been this way it's probably too big of a BC to fix now. Just reporting this for the next major release.

Richtermeister avatar Jan 28 '15 22:01 Richtermeister

@Richtermeister I am sorry to come to you too late about it. I am including this issue into the 0.4 milestone.

akovalyov avatar Jan 16 '16 01:01 akovalyov

@akovalyov Awesome, thank you!

Richtermeister avatar Jan 16 '16 02:01 Richtermeister