Gaufrette icon indicating copy to clipboard operation
Gaufrette copied to clipboard

Remove Gaufrette\Adapter\AwsS3 capability of silence exceptions

Open robertodormepoco opened this issue 10 years ago • 5 comments

I really don't know if there's some BC reason to those "return null" (i.e. exceptions catch in read() and write() methods). For any reason if there's something wrong with credentials (signature) there will be no hint at runtime (a colorful "null" at most), this is really bad.

robertodormepoco avatar Nov 01 '14 15:11 robertodormepoco

bump?

robertodormepoco avatar Nov 11 '14 07:11 robertodormepoco

Is there a way to find or display those errors currently ?

ima-tech avatar Dec 15 '14 19:12 ima-tech

+1 to this. It makes debugging S3 server responsive unnecessarily difficult. I'd be happy to provide a pull request if there isn't a reason to catch these exceptions.

brettp avatar Mar 20 '15 17:03 brettp

Unfortunately, the Adapter interface currently specify that it must return false on failure instead of throwing exception (which is totally bad design, I agree). changing this is a BC break though.

A full rewrite of Gaufrette has started on https://github.com/Gaufrette/ though

stof avatar Mar 20 '15 18:03 stof

Thanks for the info. Glad to hear this is being addressed in the next version.

brettp avatar Mar 21 '15 15:03 brettp