DoctrineBehaviors
DoctrineBehaviors copied to clipboard
KnpLabs
Update Subscribers with #[AsDoctrineListener]
To remove the deprecation from implementing the EventSubscriberInterface this PR is to use the #[AsDoctrineListener] attribute instead.
To do so I set the doctrine/doctrine-bundle to ^2.7.2.
Running the cs-fixer, phpstan and rector showed a couple of errors so I updated Rector and implemented some of the changes that those tools required.
There were errors in the github workflows so I updated the versions of the actions accordingly.
If there is more to update let me know I would be happy to help.
Looking at the current PRs this seems to be a combination of
https://github.com/KnpLabs/DoctrineBehaviors/pull/739
https://github.com/KnpLabs/DoctrineBehaviors/pull/741
https://github.com/KnpLabs/DoctrineBehaviors/pull/738
https://github.com/KnpLabs/DoctrineBehaviors/pull/736
I updated the tests some more and added support for Symfony 7. I dropped support for Symfony5 and PHP 8.0
This kind of takes the PR #750 into account aswell.
Hello 👋
Any updates about this PR? 😀
Nothing so far 😕I use my fork on multiple projects waiting for it to get merged
I really don't understand... What is the problem with releasing this one very important feature? It is just a few minutes...
@jgrygierek The problem is, that this library does not seem to have any active maintainers for quite some time. See #711
@alexpozzi
Thanks for the reply.
I will take another look at it when I get back from vacation in two weeks.
There are some changes with Symfony 6.1 which make it difficult to use 6.0 as the lowest version. I updated the composer.json to only allow symfony 6.1 and php 8.1.
The changes of some of the variables is the current Rector behaviour so we might aswell keep it like that.
If this gets merged the next thing that might have to be updated is the doctrine ORM from v2 to V3 but doing that here makes it a bit too much in one PR.
