koGrid doesn't set checkbox properly -with code fix

[ricred]

When trying to set checkbox the toggleSelected return undefined value, stopping the check event chain and thereby isn't the checkbox "visually set".

Fix for my particular problem was to make the following change (line 1109)

from: afterSelectionChange: function () { }, to: afterSelectionChange: function () { return true; },

since the return statement on line 1633: return self.afterSelectionChange(self, event); returns undefined without the "fix" and causing the mentioned problem.

[IvanSokalskyi]

Thank you, it's working just perfect.

[anandsk123]

Awesome, I just came across this post, and it solved my problem too! Thanks to ricred!!!!

[alecialene]

Excellent! This fix made the difference between using the grid and not for our app. Thanks!

[sudarshan89]

Thanks fixed the problem. A JSFilddle to reproduce the problem http://jsfiddle.net/sudarshan89/m4z2z/10/

[kiaplayer]

Thanks a lot! Why it is not in master yet?

[ImaginaryDevelopment]

is there a way to apply this fix without modifying the source? like changing it after the lib is loaded?

[kiaplayer]

@ImaginaryDevelopment, I think you can fix it with config option:

 <div data-bind="koGrid: { data: items, afterSelectionChange: function () { return true; } }"></div>

Look at this: koGrid-2.1.1.debug.js, line 886

[ImaginaryDevelopment]

yup thanks

[steedums]

Thanks Kiaplayer. Works great.

[ZiadJ]

Thanks, your solution saved my day!

[Taguiar84]

and....... not in master yet!!!!!!! :(

[ctthang]

Works! I try to bind checkbox's change event and it does not work :(

[crissdev]

Updated jsFiddle provided by @sudarshan89 http://jsfiddle.net/onh86fas/