Knockout-Validation icon indicating copy to clipboard operation
Knockout-Validation copied to clipboard
verified publisher icon Knockout-Contrib

Consistent coding style suggestions

Open crissdev opened this issue 11 years ago • 4 comments

I'm considering making some changes which should help us have a more maintainable and uniform source code. Here's what I have in mind:

  • make all directories lowercase (Dist -> dist, Src -> src)
  • ensure consistent coding style using http://editorconfig.org/
  • use spaces instead of tabs - e.g. gruntfile looks really bad when open in Github
  • add more JSHint rules

Although it's not critical to implement this right now, I want to have some feedback before going further. I would prefer to have this pushed to v2 release since we have a lot of changes since last release and it would be a good time for it - v2 release notes here.

Feel free to share your ideas to make this project better.

crissdev avatar Dec 23 '14 23:12 crissdev

Bower. Then when/if you change your structure in future we can just keep installing it the same as always.

mryellow avatar Dec 28 '14 02:12 mryellow

Thanks @mryellow bower.json will be added to the project and included in 2.0 release - #497

crissdev avatar Jan 07 '15 10:01 crissdev

https://github.com/jscs-dev/node-jscs

khakulov avatar Jan 16 '15 08:01 khakulov

Great suggestion Azim. Thanks.

crissdev avatar Jan 18 '15 11:01 crissdev