add recipes to empty teapots (hot or cold)

[jshipley]

Added two new items:

• Cup of Hot Water -> consumable like tea, but doesn't have any benefit
• Cup of Frothed Milk -> not as filling as hot cocoa, and will remove one status effect like milk (regardless of cocoa configuration)

Also added several new recipes:

• Crafting unheated water or milk teapot with an empty bucket will transfer the milk/water to the bucket
• Crafting hot water or frothed milk teapot with teacup will give cup of hot water or cup of frothed milk
• Tea / cocoa recipes can be crafted with cup of hot water / frothed milk as well as with heated teapots.

Closes #47

Happy Modtober 2024!

[KnightMiner]

Overall a great start. Most of the comments are some namespacing issues with the recipes, and a couple of recipes you missed adding.

Cup of Frothed Milk -> not as filling as hot cocoa, and will remove one status effect like milk (regardless of cocoa configuration).

I left some comments, but it should definitely have its own config, just a different default.

Lets default cocoa to "clear a random positive effect" and default milk to "clear a random effect, positive or negative".

Should also have low food values, since there is no milking delay so milk is a nearly free food source; its the cocoa beans that make hot cocoa restore most of its hunger.

Crafting unheated water or milk teapot with an empty bucket will transfer the milk/water to the bucket

I'm not sure I like this recipe. I think I'd rather just treat the filled pots as "fluid handler items" and support emptying them into tanks, so it be the domain of #46.

You could also let the player just dump out a filled but not hot teapot by right clicking a block with it. No need to place a fluid, but play a nice sound like dumping a bucket (and if you want to be very fancy, throw in some water/milk particles). Should require the player to be sneaking to do so. At that point, sneak+right click could dump a hot teapot too. Note there is a good chance this feature would conflict with #57 as both require adding a class for filled not-hot teapots.

Tea / cocoa recipes can be crafted with cup of hot water / frothed milk as well as with heated teapots.

I like this idea, just make sure all the recipes are the same (you were missing a couple, and cooca had too few beans, I don't want a discount because you used a cup or used a pot).

[jshipley]

This will need #57 to completely work, so I'm going to convert it into a draft until that's complete and merged in.

The recipe are cleaned up, frothed milk is set up with a config, and teapots can be dumped. I even added new splash particles for the milk.

[jshipley]

1.20 branch merged in (including #57), and frothed milk with cinnamon recipe added

[jshipley]

Was there something else you still wanted me to change?

[KnightMiner]

Apologizes, I have been focused on other projects. Not sure when I'll come back to this one but may be a little bit.