fastapi-health icon indicating copy to clipboard operation
fastapi-health copied to clipboard

RFC draft for health check not supporting APIRouter

Open harochau-gamemod opened this issue 2 years ago • 0 comments

I'm using inreleased version of this package

app.add_api_route("/internal/health", HealthEndpoint(conditions=[live_condition]), ) app.add_api_route("/internal/ready", HealthEndpoint(conditions=[ready_condition]), ) works

r = APIRouter() r.add_api_route("/internal/health", HealthEndpoint(conditions=[live_condition]), ) r.add_api_route("/internal/ready", HealthEndpoint(conditions=[ready_condition]), ) app.include_router(r) fails because it returns ready_condition for both endpoints

harochau-gamemod avatar Dec 08 '22 12:12 harochau-gamemod