Bulk-Crap-Uninstaller icon indicating copy to clipboard operation
Bulk-Crap-Uninstaller copied to clipboard

[WIP] Context menu

Open zbalkan opened this issue 2 years ago • 5 comments

This is a work in progress.

The PR solves https://github.com/Klocman/Bulk-Crap-Uninstaller/issues/331. It fulfills the minimum requirements. It is hard to test shell extensions.

zbalkan avatar May 13 '22 14:05 zbalkan

Let me know when it's ready for review, I'll look into it for the next release.

Klocman avatar May 20 '22 14:05 Klocman

This is a work in progress.

The PR solves #331. It fulfills the minimum requirements. It is hard to test shell extensions.

Is there a reason why you explicitly get the shortcut target file by using binary file reading? Optionally it's possible to implement it without calling for a filestream, which sounds more performant in my eyes (correct me if I'm wrong please). e.g. this stackoverflow post

Please think about it if you're still working on this.

Ivanmatthew avatar Mar 06 '23 14:03 Ivanmatthew

Hi @Klocman,

Life happened I couldn't work on this, and actually, I even forgot I worked on this.

When I checked the So page you mentioned, I saw the comment which I used as a reference: https://stackoverflow.com/a/29749787/5910839

It is actually in the comments of GetShortcutTarget method. The intent was to minimize the dependencies but eventually it got out of that direction. In order to simplify, using Shell32 may be easier to implement. But it needs to be tested. I cannot work on it in the short term.

Feel free to close, archive, edit or rewrite the PR.

N.B: Sorry for the late response.

zbalkan avatar Mar 06 '23 14:03 zbalkan

Pls Update - Has this not yet been implemented?

SannyQ avatar Dec 07 '23 08:12 SannyQ

This was never a part of the road map but an optional thing. I implemented the basics yet it is far from perfect. If you like, you can try to compile and alpha-test my version so that we can fix the issues beforehand.

zbalkan avatar Dec 07 '23 08:12 zbalkan