klipper icon indicating copy to clipboard operation
klipper copied to clipboard

ads1220: Expose registers for FIR filter, power switching, etc. as configuration variables

Open EllaFoxo opened this issue 8 months ago • 1 comments

This provides the registers of the ADS1220 as configurable parameters for the end user.

Different implementations of the ADC will have varying use cases, therefore it is worthwhile to have these available.

Especially useful is the IDAC, when no external voltage reference is present on the input_mux line. For example, when the user is using the built-in source, or the analog supply line, they can use the IDAC to set a predetermined amount of current to be used for reading across a bridge.

The ADS1220 also contains a built-in FIR filter for 50/60Hz noise rejection, which can prove very useful if the ADC is situated close to a switching mode power supply. For load cell probing, this is also done in a software filter, as other chips may lack this capability. Specifically for the ADS1220 however, it should speed up the processing time of load cell probe analysis by using the hardware filter.

Signed-off-by: Ella Fox [email protected]

EllaFoxo avatar Apr 24 '25 15:04 EllaFoxo

@garethky - fyi.

-Kevin

KevinOConnor avatar May 03 '25 18:05 KevinOConnor

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar May 18 '25 00:05 github-actions[bot]