klipper icon indicating copy to clipboard operation
klipper copied to clipboard

tweak: be tolerant of missing newlines at EOF

Open Laikulo opened this issue 9 months ago • 3 comments

This adds a final pass through virtual_sdcard's line pumper to avoid losing the last block of a file if it is unterminated.

Laikulo avatar Mar 24 '25 22:03 Laikulo

(had a minor fight with the linter)

Laikulo avatar Mar 24 '25 23:03 Laikulo

Unless I'm mistaken, this seems to be the same as #6565, you might want to take a look to understand the reasoning behind the current behaviour.

pedrolamas avatar Apr 02 '25 23:04 pedrolamas

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Apr 17 '25 00:04 github-actions[bot]