ICM20948: handle i2c errors

[nefelim4ag]

Another part of I2C error handling.

Mostly the same patch set can be added next for the MPU.

Thanks.

[phansel]

@nefelim4ag do you have ICM20948 in hand or would you like me to test these changes?

[nefelim4ag]

@phansel,

do you have ICM20948 in hand or would you like me to test these changes?

Unfortunately, I do not have one, so it would be really nice of you to test it.

Thank you.

Btw, I suspect overflow counting will not work as expected. The rate of query_status is far lower than the rate to pull data from the FIFO. So, it will not be able to actually count possible overflows.

Not sure how severe it actually is, to count it properly. Looks like it is just not used anywhere.

[MRX8024]

I ran tests with the new patch. Debug messages is output once per second, summed up over intermediate batches.

100k bus:

400k bus:

Also for your information, with both old and new code, sometimes there is a static number of overflows:

Either the first data has overflows:

[github-actions[bot]]

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.