klipper icon indicating copy to clipboard operation
klipper copied to clipboard

config: add warning about new-stock ender 3s

Open BluCobalt opened this issue 1 year ago • 5 comments

My Ender 3 (bought in 2021?) came with a 4.2.2 board out of the box. I just want to add this note to hopefully help someone else, because I lost a good couple of hours trying to figure this out ;)

BluCobalt avatar Nov 06 '24 18:11 BluCobalt

Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks James

JamesH1978 avatar Nov 07 '24 11:11 JamesH1978

Should be good now.

BluCobalt avatar Nov 07 '24 17:11 BluCobalt

Thanks, looks fine to me as an informational, as this is indeed the case. The other option would be to create a whole new file referencing the date these started shipping without the melzi boards, but I think that could get confusing. @KevinOConnor what do you think?

Thanks James

JamesH1978 avatar Nov 08 '24 08:11 JamesH1978

Actually, that might make more sense. A little bit of research says that this hardware change happened in July of 2020. Let me make that new config.

BluCobalt avatar Nov 08 '24 17:11 BluCobalt

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Nov 23 '24 00:11 github-actions[bot]