klipper icon indicating copy to clipboard operation
klipper copied to clipboard

Adding LIS3DH support

Open FLYmaker opened this issue 1 year ago • 2 comments

Based on the code from [pull request #6477 , the code has been merged into lis2dw.py and lis2dw.c. When using lis3dh, only need to add :

is_lis3dh: True

[lis2dw] is_lis3dh:True cs_pin: SHT36:gpio9 spi_software_sclk_pin: SHT36:gpio10 spi_software_mosi_pin: SHT36:gpio11 spi_software_miso_pin: SHT36:gpio12

FLYmaker avatar Jul 09 '24 09:07 FLYmaker

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line.

Thanks James

JamesH1978 avatar Jul 09 '24 22:07 JamesH1978

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Jul 24 '24 00:07 github-actions[bot]

@FLYmaker I can try testing this on a Duet1LC if you add I2C operation.

Wulfsta avatar Oct 10 '24 22:10 Wulfsta

Hi. Can I connect LIS3DH via I2C? How to configure it?

VitaliyKrym avatar Mar 18 '25 13:03 VitaliyKrym

Hi. Can I connect LIS3DH via I2C? How to configure it?

Pull Requests are neither suited for nor used as place to request help. See the LIS3DH Klipper documentation or refer to https://github.com/Klipper3d/klipper/blob/master/docs/Contact.md for further assistance.

Closing as resolved with #6715.

Sineos avatar Mar 18 '25 13:03 Sineos