klipper icon indicating copy to clipboard operation
klipper copied to clipboard

Bugfix: [homing_heaters] not working with heater_generic

Open whyme12 opened this issue 1 year ago • 1 comments

Module: heaters: [homing_heaters] not working with heater_generic.

Currently the heater in [homing_heaters] has to be set as heater_generic my_heater while on a homing or probing move it is checked for the heater name my_heater, which can't be found. With this fix, the config check requires my_heater to be defined which matches the later check when homing or probing As far as I can tell, no impact on other things, as get_all_heaters() is only used in homing_heaters.py.

Signed-off-by: Robin Ehnert [email protected]

whyme12 avatar Jun 20 '24 10:06 whyme12

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Jul 04 '24 12:07 github-actions[bot]