klipper icon indicating copy to clipboard operation
klipper copied to clipboard

Update printer-creality-ender6-2020.cfg

Open Neelrhi opened this issue 1 year ago • 3 comments

Added in dimensions for the the custom 3D-printed mount.

Neelrhi avatar May 11 '24 02:05 Neelrhi

Thankyou for submitting a PR, our stock configurations are for bone stock printers as if they have just come out of the box from factory, as users may not have custom additions. This printer did not ship with a bltouch as standard, so therefore the code for it is commented out and left for the user to uncomment if they add this option.

Thanks James

JamesH1978 avatar May 11 '24 10:05 JamesH1978

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar May 25 '24 12:05 github-actions[bot]

@Neelrhi I'm unsure that this PR adds significant value. As noted by James the Creality Ender 6 did not ship with a BLTouch, so such a configuration should never be the default for this printer. The commented out section in the current source represents the typical 'from Vendor' addition. Adding as default, configurations for additional 3rd party items would almost certainly result in confusion for end users.

I believe you should close this PR.

bevanweiss avatar Sep 08 '24 09:09 bevanweiss

If I had to guess, this user mistakenly opened this PR.

zimmertr avatar Sep 26 '24 21:09 zimmertr

This PR is being closed because it is currently not considered a good match for the master Klipper repository.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Oct 04 '24 00:10 github-actions[bot]