klipper icon indicating copy to clipboard operation
klipper copied to clipboard

Add config files for Recore A6, A7 and A8

Open eliasbakken opened this issue 10 months ago • 2 comments

The ina381 is a current monitor circuit with over current alarm. In order for Recore boards to work, this circuit needs a reset and that is what this plugin does.

Signed-off by: Elias Bakken [email protected]

eliasbakken avatar Apr 14 '24 09:04 eliasbakken

I've implemented this PR as a pure config file change as pr your suggestion.

eliasbakken avatar May 02 '24 19:05 eliasbakken

Thanks. In general, it seems fine to me. At a minimum the configs need to be added to the build test cases though ( https://www.klipper3d.org/Example_Configs.html point 4).

@JamesH1978 - do you have any comments?

-Kevin

KevinOConnor avatar May 14 '24 15:05 KevinOConnor

Config looks fine, my only main comment would be why you have such a low min_extrude_temp and a min_temp of 1 kelvin for your extruders?

Once the regression tests are added as per Kevin's comment, i will do a few review.

Thanks James

JamesH1978 avatar May 15 '24 07:05 JamesH1978

Thank you both. I've added the config files as tests, but in order to make them pass I had to make some code changes, so I'll try and submit that as a separate PR that can be reviewed first.

eliasbakken avatar May 25 '24 13:05 eliasbakken