klipper icon indicating copy to clipboard operation
klipper copied to clipboard

Initial commit for TronXY X5SA-2E printer config.

Open patchMonkey156 opened this issue 2 years ago • 1 comments

as the [shared_heater] tag is deprecated, it was avoided in favor the T0 and T1 macros that are already necessary.

This config should be considered "initial" in that the user can rely on the pinouts, but needs to configure most of the other details themselves using the printer and SuperSlicer or some equivalent.

Pinouts for your tronXY printer on this motherboard can be mined from their GitHub project for the TronXY Marlin firmware.

This printer's pinouts were mined from https://github.com/tronxy3d/F4xx-SIM480x320/blob/firmware/Marlin/src/pins/stm32f4/pins_TRONXY_F446.h

The File for some Single extrusion variants of the F446 boards: https://github.com/tronxy3d/F4xx-SIM240x320/blob/firmware/Marlin/src/pins/stm32f4/pins_TRONXY_F446.h The file for Legacy F103 Boards: https://github.com/tronxy3d/STM32F103-PIC480x320/blob/firmware/Marlin/src/pins/stm32f4/pins_TRONXY_F446.h

patchMonkey156 avatar Jan 14 '23 10:01 patchMonkey156

Hi,

thank you for submitting your config.

Please can you make sure you have followed the guidelines in https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md and https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md paying particualr atetntion to the signed off by line and the printer regression test case that you need to add to.

Thanks James

JamesH1978 avatar Jan 14 '23 20:01 JamesH1978

As per my last comment, i have noted a few changes.

You need to read https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md especially the signed off by line

You also need to refer to https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md especially point 4 and add the regression tests

I have also made a few initial comments to the code.

Thanks James

I believe that is the format for the signed-off-by line? Thank you for the guidance.

The regression tests? Will take a bit longer as I read the documentation on how to address this. Thank you for your assistance!

patchMonkey156 avatar Jan 24 '23 17:01 patchMonkey156

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Feb 08 '23 00:02 github-actions[bot]

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Feb 22 '23 12:02 github-actions[bot]