klipper icon indicating copy to clipboard operation
klipper copied to clipboard

Allow bedmeshing at 1mm spaced intervals.

Open kmobs opened this issue 2 years ago • 3 comments

With the advent of newer probes, meshing at 1mm may be something desired by the end user.

kmobs avatar Dec 02 '22 00:12 kmobs

yes please

theolas avatar Dec 02 '22 17:12 theolas

This change looks ok to me. Please see the contributing documentation for details on how to format the commit message. Specifically, all commits need a signature with your real name and valid email address. Thanks.

Arksine avatar Dec 02 '22 17:12 Arksine

Done. Thank you @Arksine.

kmobs avatar Dec 02 '22 17:12 kmobs

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Dec 17 '22 00:12 github-actions[bot]

Happy to commit this when it is thought to be ready.

-Kevin

KevinOConnor avatar Dec 17 '22 16:12 KevinOConnor

@KevinOConnor I believe it is ready, and the commit now has a sign-off

kageurufu avatar Dec 18 '22 19:12 kageurufu

assigning myself to review so kmobs will stop whining in dm's.

mental405 avatar Dec 18 '22 19:12 mental405

Seems like a trivial change since presently one could do a mesh at 1.01mm spaced intervals vs 1.00mm spaced intervals without issue. I see it as more or less a bug fix than a feature addition.

mental405 avatar Dec 18 '22 19:12 mental405

Thanks.

-Kevin

KevinOConnor avatar Dec 19 '22 16:12 KevinOConnor