Klemen

Results 255 comments of Klemen

> > Make it so that extensions need not to be changed. > > It will introduce more changed lines than currently as to make it work (currently), I added...

You need to re-apply extension on saving, maybe make method to get texture with png extension. But see, once again, you did not test at all but did a minute...

> I found a fix and in no case, I would have been able to find the bug just by testing myself, only tests could report it. The PR was...

Conflict was this change: https://github.com/MCreator/MCreator/commit/7fb7b501940d6fe74cf8492973b377e29987f2c9 Please make sure this change is present in your PR

I will mark this draft until mappings are done (which means until data lists are merged)

> I meant I will add mappings when data lists will be merged, but they will come in another PR. I know, but I think they should be in this...

What is the purpose of crafting_ingredient and why will this PR be needed? Also please test on your own branches and open PR once it is ready here, otherwise, we...

> It's a key part of custom item properties feature. But why would we need multiple files for item properties?

There is merge conflict

currentItem for current item, not toString