gulp-run-command icon indicating copy to clipboard operation
gulp-run-command copied to clipboard

Mark all Options parameters as optional

Open qtiki opened this issue 5 years ago • 3 comments

Currently the types enforce you to either A) provide no options or B) provide a value for every option. In reality they all have default values and can be left "undefined" so they should be optional in the types too.

qtiki avatar Feb 18 '20 14:02 qtiki

I was going to open an issue about this but then I figured it's such an easy fix I'll just do the PR. Basically the types as they are now can break TypeScript compilation for users of this library when they update, which is what happened to us. We are using only the cwd option but the compiler throws an error about it.

qtiki avatar Feb 18 '20 14:02 qtiki

@Klathmon -- any update on this?

tianhuil avatar Apr 08 '20 16:04 tianhuil

Any update on this? I'm currently using patch-package to patch this fix in.

scottbot95 avatar Jun 11 '20 04:06 scottbot95