Gerrit Uitslag

After a quick look I could not spot a conversion to lower case yet. https://github.com/selfthinker/dokuwiki_plugin_wrap/blob/81450d7519e8f4da56e6fb2b8dcc98e1a01648ff/helper.php#L82 https://github.com/selfthinker/dokuwiki_plugin_wrap/blob/81450d7519e8f4da56e6fb2b8dcc98e1a01648ff/helper.php#L135 However, after another look, I suspect this is already lowering it: https://github.com/selfthinker/dokuwiki_plugin_wrap/blob/81450d7519e8f4da56e6fb2b8dcc98e1a01648ff/syntax/span.php#L43 For a...

Can you complete the pull request with an unit test? For examples of unit tests you can have a look at https://github.com/mpdf/mpdf/tree/development/tests/Issues Thanks in advance!

Thanks for the PR! Did you test, could this work? The string flag is missing, now only argument number is added. I expected e.g. `%2$s`.

Could you add an unit test to ensure it will not reappear in the future? See for examples: https://github.com/mpdf/mpdf/tree/development/tests/Issues SVG specific https://github.com/mpdf/mpdf/blob/development/tests/Mpdf/Image/SvgTest.php But maybe a general one is more practical.