Klaas Demter

Results 125 comments of Klaas Demter

Diff to make it work in the direction of downgrading pinned versions: ``` diff --git a/requirements.txt b/requirements.txt index fd6953f..f248004 100644 --- a/requirements.txt +++ b/requirements.txt @@ -6,46 +6,46 @@ azure-cli-core==2.64.0 azure-common==1.1.28...

some of those requirements are not even in latest version of azure cli :) https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/requirements.py3.Linux.txt Diff to make it work with the latest azure-cli version: ``` diff --git a/requirements.txt b/requirements.txt...

Hi @Fred-sun I think you just installed azure collection after you installed azure-cli? Just looking at those two lines: https://github.com/Azure/azure-cli/blob/ccc6fd5065c4aaa4e63383dce9ca64b7c50380ee/src/azure-cli/requirements.py3.Linux.txt#L7 (not sure why this is not showing the preview, but...

If you had a look at this, give me a heads up and I'll write tests for it.

Hi @Fred-sun I've fixed everything, except for long lines on the URLs, how can I fix those without breaking the link?

I did not find a good way to get ansible to show the link without breaking it. Can we ignore the line length, shall I make exceptions for those lines?

@Fred-sun added the test cases, addressed your other concerns from the log alert info module in this info module as well

> The name descriptions under the same task should not be the same. Thank you! > > ``` > tests/integration/targets/azure_rm_loganalyticsworkspace/tasks/main.yml > > line 279, 289, 298 same description: Assert that...

Changed the json queries to map|list

> Added in [#1952](https://github.com/ansible-collections/azure/pull/1952) I guess you mean #1955 :)