Martin Habovštiak
Martin Habovštiak
I agree it's impossible but I also agree that an already `unsafe` function required to handle invalid inputs is unfortunate.
That would be a nice way to transition into it becoming unsound at some point (with breaking change).
I think that hiding old report rather than editing would be also an acceptable solution. It does spam GH notifications but it looks better in the comment history since it...
Maybe worth moving some things to `ln-types`? `ChannelId` definitely sounds like one of them.
I don't see any such dependency - the type contains just `[u8; 32]`. If you are referring to some methods having `lightning` types in their signatures that is solvable using...
Just one note regarding updating a final BIP: there's a huge difference between documenting which parameters people use (the spec specifically allows using custom parameters) and documenting that everyone actually...
> The semver hack will be used to allow Tokio to upgrade from v1 without a breaking change. I'm not sure if `tokio` can depend on `bytes` 2.0 in practice....
> Also, a `bytes-core` that only has trait definitions would solve this issue. This was discussed recently, it's not possible because the traits contain `Bytes` in their public API.
> Just a heads up, it is impossible for me (or anyone new to the party) to keep up with the discussion if it takes place in multiple places The...
@Tom01098 sadly, that cannot be done using semver trick.