clyde icon indicating copy to clipboard operation
clyde copied to clipboard

Clyde reports incorrect sizes

Open Daenyth opened this issue 14 years ago • 4 comments

daenyth@Bragi ~ $ sudo clyde -S bin32-acroread
:: bin32-acroread package not found, searching for group...
:: bin32-acroread group not found, searching AUR...

==> Installing the following packages from repos

Targets (38): lib32-gtk2-2.18.7-1  lib32-pcre-8.01-1  lib32-libstdc++5-3.3.6-3  
             lib32-libxdamage-1.1.2-1  lib32-libxml2-2.7.6-2  rpmextract-1.0-3  lib32-libtiff-3.9.2-2  
             lib32-atk-1.28.0-1  lib32-pango-1.26.2-1  lib32-libxcursor-1.1.10-1  
             lib32-libxinerama-1.1-1  lib32-libxrandr-1.3.0-1  lib32-libxi-1.3-2  
             lib32-libcups-1.4.2-3  lib32-heimdal-1.3.1-3  lib32-openssl-0.9.8m-2  
             lib32-libxfixes-4.0.4-1  lib32-libjpeg-8.0.1-1  lib32-glib2-2.22.4-1  
             lib32-cairo-1.8.10-1  lib32-libxft-2.1.14-1  lib32-gnutls-2.8.5-1  lib32-libpng-1.4.1-1  
             lib32-e2fsprogs-1.41.10-1  lib32-db-4.8.26-1  lib32-fontconfig-2.8.0-1  
             lib32-pixman-0.16.6-1  lib32-xcb-util-0.3.6-1  lib32-opencdk-0.6.6-1.1  
             lib32-libtasn1-2.4-1  lib32-lzo2-2.03-1  lib32-readline-6.1.002-1  
             lib32-util-linux-ng-2.17.1-1  lib32-expat-2.0.1-5  lib32-freetype2-2.3.12-1  
             lib32-libgcrypt-1.4.5-1  lib32-ncurses-5.7-2  lib32-libgpg-error-1.7-2  

Total Download Size:    0.00 MB
Total Installed Size:   29.14 MB

None of the above were already downloaded, and the installed size was wrong also.

Daenyth avatar Mar 19 '10 18:03 Daenyth

Due to a limitation in libalpm this is not trivial to fix. I may just remove the information about size. That or I will have to do huge amount of refactoring and it might end up worse off.

Kiwi avatar Mar 20 '10 00:03 Kiwi

How is there a limitation when pacman is able to display the correct sizes?

Daenyth avatar Mar 20 '10 01:03 Daenyth

Clyde is able to display the correct packages too, in the places pacman does.

In my opinion, and others, as shown in the link at the end of this post, pkg_download_size is broken in libalpm.

The issue is that pkg_download_size() will only report size of packages after a sync_prepare (which is done in trans_prepare(data)) which is done in a different spot and on the list of packages that have been added with alpm_trans_addtarget, which is done before the aur packages and their dependencies are added to the list to be installed and displayed.

http://www.mail-archive.com/[email protected]/msg01319.html

Kiwi avatar Mar 20 '10 01:03 Kiwi

Ah, that makes more sense.

Daenyth avatar Mar 20 '10 02:03 Daenyth