ITKContourInterpolation icon indicating copy to clipboard operation
ITKContourInterpolation copied to clipboard

ENH: Bump for ITK v5.3.0

Open tbirdso opened this issue 3 years ago • 6 comments

Includes update to use CI reusable workflow

Closes #108 #107

tbirdso avatar Dec 05 '22 17:12 tbirdso

Working on a resolution for cxx path length issues

tbirdso avatar Dec 05 '22 18:12 tbirdso

Depends on https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/pull/23

tbirdso avatar Dec 06 '22 23:12 tbirdso

Unfortunately updating the ITK cxx reusable workflow to accommodate longer module path lengths will take more effort than anticipated. For this PR I've pivoted to update the cxx workflow inline for v5.3.0 and only use the Python reusable workflow.

tbirdso avatar Dec 09 '22 01:12 tbirdso

Seeing unexpected issue where a different set of 3 or 4 tests fail every run?

Run 1:

2022-12-09T15:23:39.4128068Z The following tests FAILED:
2022-12-09T15:23:39.4132033Z 	258 - itkMCIRLE_105769fixed_C_-1_0 (Subprocess aborted)
2022-12-09T15:23:39.4132605Z 	305 - itkMCI_64816L_amygdala_int_C_2 (Subprocess aborted)
2022-12-09T15:23:39.4133096Z 	468 - itkMCIRLE_64816L_amygdala_fin_C_2_3 (Subprocess aborted)

Run 2:

2022-12-09T02:25:38.9748902Z The following tests FAILED:
2022-12-09T02:25:38.9751851Z 	204 - itkMCIRLE_105769moving_C (Subprocess aborted)
2022-12-09T02:25:38.9752453Z 	295 - itkMCI_64816L_amygdala_int_T_0 (Subprocess aborted)
2022-12-09T02:25:38.9753032Z 	410 - itkMCIRLE_64816L_amygdala_fin_T_0_1 (Subprocess aborted)

Failures all show as system errors:

2022-12-09T02:12:57.8690559Z 410/730 Test #410: itkMCIRLE_64816L_amygdala_fin_T_0_1 ...............Subprocess aborted***Exception:   1.02 sec
2022-12-09T02:12:57.8691387Z <DartMeasurement name="ImageError 64816L_amygdala_fin_T_0_1.nii.gz" type="numeric/double">0</DartMeasurement>
2022-12-09T02:12:57.8691950Z <DartMeasurement name="BaselineImageName" type="text/string">64816L_amygdala_fin_T_0_1.nii.gz</DartMeasurement>
2022-12-09T02:12:57.8692832Z terminate called after throwing an instance of 'std::system_error'
2022-12-09T02:12:57.8693241Z   what():  Operation not permitted

tbirdso avatar Dec 09 '22 16:12 tbirdso

Possibly due to running out of memory.

dzenanz avatar Dec 09 '22 16:12 dzenanz

Attempt 3 passed, will move forward with merge as-is (once approved)

@dzenanz Are you ready for this to be merged and tagged?

tbirdso avatar Dec 09 '22 17:12 tbirdso