fletch
fletch copied to clipboard
Kitware
Suggest disabling eigen tests in its build
Should speed up the build
-DBUILD_TESTING:BOOL=OFF https://github.com/Kitware/fletch/blob/50144cf442522040d0f39bd2e60a616b1aa23db5/CMake/External_Eigen.cmake#L15
Ok, this approach just fails for Eigen. Their CMake code is a bit of a mess. I can patch the CMakeLists.txt to remove the tests but I don't really know if it's worth it. Building without tests takes 6 seconds and only 11 seconds with tests. Agreed that it's nearly twice as fast, but considering I could have built Eigen 10 times in the time it took me to write this comment, I don't know if I see the value.
That is weird, I have been using it with out issue, maybe fletch has an old version of Eigen?
No big deal, I thought it would be a quick fix
That's possible. Also possible is that it works on Windows and not on Linux. I think we should keep this issue open for now because I'm going through all of the packages in Fletch and upgrading versions as possible. Once I get to Eigen, I can try your suggested patch again.
On Fri, Jul 10, 2020 at 1:17 PM Aaron Bray [email protected] wrote:
That is weird, I have been using it https://gitlab.kitware.com/physiology/engine/-/blob/master/cmake/external/External_Eigen3.cmake with out issue, maybe fletch has an old version of Eigen?
No big deal, I thought it would be a quick fix
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Kitware/fletch/issues/590#issuecomment-656788731, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKEAWQOALIPP4J5D46W2PLR25ELNANCNFSM4OWVJ2JA .
-- David Stoup Principal Engineer
Kitware, Inc.
1712 Route 9, Suite 300 Clifton Park, NY 12065-3104 518-881-4949 (W) 518-312-3946 (M) 518-371-4573 (F)
This works on linux too (I stole the idea from ITK, so I am pretty sure its not an OS thing)
Sounds good, keep me posted if you need anything