fletch icon indicating copy to clipboard operation
fletch copied to clipboard

Update VXL and ITK

Open mattdawkins opened this issue 6 years ago • 18 comments

VXL update was required for the ITK version

mattdawkins avatar Dec 28 '18 20:12 mattdawkins

Can one of the admins verify this patch?

kwcvrobot avatar Dec 28 '18 20:12 kwcvrobot

You can... talk?

mattdawkins avatar Dec 28 '18 22:12 mattdawkins

If this patch fixes the upstream VXL's ffmpeg issue then please push it there instead of making a fletch patch. I can approve and merge VXL branches so I would prefer not patching locally.

dstoup avatar Jan 02 '19 15:01 dstoup

jenkins test this please

dstoup avatar Apr 11 '19 15:04 dstoup

Having looked at the diff in the VXL patch, is there a good reason we don't push this into that repo? Also, why don't we go closer to master? Is something else broken?

dstoup avatar Apr 11 '19 15:04 dstoup

Something else was broken on latest VXL in the time period of this branch though that's fairly old now so maybe it was fixed, haven't had a chance to look at this in more detail and this branch is still broken on Windows due to a bug in VXL's build sys

mattdawkins avatar Jul 12 '19 20:07 mattdawkins

Jenkins test this please

dstoup avatar Jul 16 '19 16:07 dstoup

I have been testing recently and currently master fails on VS with link errors.

dstoup avatar Jul 23 '19 17:07 dstoup