fletch
fletch copied to clipboard
Kitware
Dev/fix opencv gotoblas
OpenCV 3.4 has an option OpenBLAS_LIB. I'm not sure if it exists in previous versions. ~~I need to check that in order to correctly set the version if statement~~ ( Turns out OpenBLAS support was added in 3.2, so I happened to guess right. ). The first function of this PR is to pass down that info when it is needed.
The second function is to fix an issue I get:
[ 97%] Linking CXX executable ../../bin/opencv_traincascade
//usr/lib/liblapack.so.3: undefined reference to `gotoblas`
collect2: error: ld returned 1 exit status
apps/traincascade/CMakeFiles/opencv_traincascade.dir/build.make:392: recipe for target 'bin/opencv_traincascade' failed
A workaround for this seems to be to set WITH_LAPACK=False. It would be better if I understood the issue more, but I don't.
I was able to get OpenCV to depend on OpenBLAS by moving the OpenBLAS tarball block to appear before OpenCV.
Mac build succeeded: https://open.cdash.org/buildSummary.php?buildid=5280095
Linux build succeeded: https://open.cdash.org/buildSummary.php?buildid=5280882
FYI, Windows didn't fail, I just stopped it while we examine review comments. We have a stack of Windows builds to get through.
Mac build succeeded: https://open.cdash.org/buildSummary.php?buildid=5316211
Linux build succeeded: https://open.cdash.org/buildSummary.php?buildid=5316371