If no data is found return empty set

[123FLO321]

If we query the db and get an empty set we should return an empty set instead of nil.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[mbarnach]

I'm re-reading the change, and I'm not so sure about it now. It is creating a discrepancy between asRows and asResultSet. If you look at the test TestQueryResult.testQueryResult, you see that we still return nil in that case. This is due to the getRows function, that first check if the asResultSet is nil, before returning the rows. If we want to be consistent, then we should also change asResultSet to return an empty result set, but that doesn't seem very doable.

I agree that empty is more consistent when no records are found, but if you look at the error, it is clear that there is no error. My opinion is that is should stay like that. @dannys42 do you want to comment/add on this one?