Swift-Kuery
Swift-Kuery copied to clipboard
Add binary and varbinary SQLDataType
Faster comparison and sorting of fields using binary and varbinary types in MySQL comparing to char and varchar. In case of binary/varbinary, comparison and sorting is based on the numeric values of the bytes in the values.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Codecov Report
Merging #124 into master will decrease coverage by
0.09%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #124 +/- ##
=========================================
- Coverage 85.25% 85.16% -0.1%
=========================================
Files 43 43
Lines 3575 3579 +4
=========================================
Hits 3048 3048
- Misses 527 531 +4
Flag | Coverage Δ | |
---|---|---|
#SwiftKuery | 85.16% <0%> (-0.1%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
Sources/SwiftKuery/SQLDataType.swift | 85.71% <0%> (-14.29%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 039375f...f4c1b1d. Read the comment docs.
Hey @Mladen-K , do the 3 SQL platforms (PostgresSQL, MySQL, and SQLite) that we support use the same notation? What I mean is does the Binary Type in Swift always translate to binary
in SQL for the 3 platforms.
In PostgreSQL, there are both data types, although they are represented as BIT and BIT VARYING. Without testing on working PostgreSQL database, I can't tell for sure wether the generated query will generate required fields with "binary" and "varbinary". SQLite doesn't support binary types...
I believe that instead of hardcoding a string in SwiftKuery, ideally we should add a case to the QueryBuilder
and then override the default binary
in Swift-Kuery-PostgreSQL to BIT
and the same for varbinary
. There is also the need to research how we handle types not being available in all three platforms, and try to take the same approach for SQLite
Ok, I'll see what I can do.
Thanks
http://www.sqlitetutorial.net/sqlite-data-types/ seems useful.
Hey @Mladen-K , any news on this?
@EnriqueL8, Just haven't had time to check it out. Sure will do in next few days.
Thanks!