BlueECC icon indicating copy to clipboard operation
BlueECC copied to clipboard

Update to use SecKeyCreateRandomKey to generate key pairs

Open LowAmmo opened this issue 2 years ago • 2 comments

SecKeyGeneratePair was deprecated with iOS 15

Upgraded to support building with Xcode 14 - with no warnings

Updated minimum supported versions -

  • MacOS - 11.5
  • iOS - 14.5
  • TVOS - 14.5
  • WatchOS - 7.5

Added in a project file to make any future modifications easy build & test with Xcode

Description

  • Changed from using SecKeyGeneratePair to SecKeyCreateRandomKey to address a deprecation warning when targetting iOS 15+
  • Eliminated all warnings seen when building with Xcode 14
  • Minimum Versions increased to more recent versions (to help with cleaning up warnings)
  • Included a project file so any future modifications are easier to make/test, etc.
    • Guessing the original maintainer already has a local project file, I'm totally okay removing mine...just thought I would include that to make future maintaining easier.

Motivation and Context

Issue: #35

Just addresses a build warning - so consumers can attempt to target a goal of 0 build warnings

How Has This Been Tested?

Via unit testing, and passivity testing our application.

Checklist:

  • [x] I have submitted a CLA form (filled out an online form as part of submitting the PR on the BlueRSA repo)
  • [x] If applicable, I have updated the documentation accordingly. (didn't see any places that needed to change)
  • [x] If applicable, I have added tests to cover my changes.

LowAmmo avatar Sep 30 '22 19:09 LowAmmo

@dannys42 - Updated to just be the relevant changes - to continue to just dynamically generate the xcodeproject

LowAmmo avatar Feb 28 '23 18:02 LowAmmo

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Mar 28 '23 23:03 sonarqubecloud[bot]